[Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

[Zachary Turner via lldb-commits]

If I'm following this discussion correctly, Greg are you saying that
ClangASTContext could be renamed to DwarfASTContext?  And that for other
types of Debug info we could have PascalASTContext and PdbASTContext?

If that's the case, then it seems there is a lot of code inside of
ClangASTContext (aka DwarfASTContext) which is not specific to DWARF, and
there's no reason that other ASTContext classes shouldn't be able to reuse
it.

On Thu, Aug 27, 2015 at 2:08 PM via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> On Thu, Aug 27, 2015 at 12:56:57PM -0700, Greg Clayton via lldb-commits
> wrote:
> > >
> > > Our Delphi compiler generates an alternate debug format as well - it
> took me all of yesterday to fix merge conflicts and I've still not got
> things working properly.  Greg, can you please move the DWARF dependencies
> back into the SymbolFileDWARF plugin?  Thanks!
> >
> > Sorry to not be clear on this: thing are correctly organized and won't
> be changing.
> >
> > You will need to merge your stuff correctly into the current world.
>
> The issue is that you have added DWARF to ClangASTContext.  How is
> another debug format plugin supposed to work in ClangASTContext now?
>
> The design had been that support for debug formats goes in plugins
> inside source/Plugins/SymbolFile.  This was a clean interface that
> allowed support for other debug formats to exist by installing their
> plugin.  Now main lldb code is polluted with DWARF code which depends on
> a plugin.
>
> Thanks,
> -Dawn
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150827/ed817a54/attachment-0001.html>