[Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot
Bhushan Attarde via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 25 05:02:52 PDT 2015
bhushan updated this revision to Diff 33063.
bhushan added a comment.
Addressed review comments.
1. Introduced Target::GetBreakableLoadAddress() instead of Target::AdjustBreakpointInDelaySlot() so that it should look more generic and targets can calculate the new breakpoint address based on whatever reason applicable to them (not restricting it to a delay-slot only).
2. Target::GetBreakableLoadAddress() does not do any work unless a target requires it.
3. Logging is enabled (under the breakpoint channel) and now mentions a reason why we changed the original breakpoint address. (In case of MIPS, the reason is a delay slot).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13889 bytes
Desc: not available
More information about the lldb-commits