[Lldb-commits] [PATCH] D12252: Reorg code to allow Windows Process Plugins to share some common code.

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 21 15:54:14 PDT 2015


amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.

In order to share some code between normal Windows debugging and Windows mini dump debugging, this is just a shuffling of files into a different hierarchy.

source/Plugins/Process/Windows/Common
  Common code for the two Windows Process Plugins.  Currently, this is just ExceptionRecord.h, but I expect this to grow as the mini dump plugin is fleshed out.  This code cannot live at a higher level (e.g., in Process/Utility) because it includes Windows-specific files.

source/Plugins/Process/Windows/Live
  Code for normal Windows debugging.  This used to be one level higher.

source/Plugins/Process/Windows/MiniDump
  Code for mini dump debugging.

Other than moving files, this includes a few necessary tweaks to CMakeLists and #include statements to reflect the new hierarchy.

http://reviews.llvm.org/D12252

Files:
  source/API/SystemInitializerFull.cpp
  source/Initialization/SystemInitializerCommon.cpp
  source/Plugins/Process/CMakeLists.txt
  source/Plugins/Process/Windows/CMakeLists.txt
  source/Plugins/Process/Windows/Common/ExceptionRecord.h
  source/Plugins/Process/Windows/DebuggerThread.cpp
  source/Plugins/Process/Windows/DebuggerThread.h
  source/Plugins/Process/Windows/ExceptionRecord.h
  source/Plugins/Process/Windows/ForwardDecl.h
  source/Plugins/Process/Windows/IDebugDelegate.h
  source/Plugins/Process/Windows/Live/CMakeLists.txt
  source/Plugins/Process/Windows/Live/DebuggerThread.cpp
  source/Plugins/Process/Windows/Live/DebuggerThread.h
  source/Plugins/Process/Windows/Live/ForwardDecl.h
  source/Plugins/Process/Windows/Live/IDebugDelegate.h
  source/Plugins/Process/Windows/Live/LocalDebugDelegate.cpp
  source/Plugins/Process/Windows/Live/LocalDebugDelegate.h
  source/Plugins/Process/Windows/Live/ProcessWindows.cpp
  source/Plugins/Process/Windows/Live/ProcessWindows.h
  source/Plugins/Process/Windows/Live/ProcessWindowsLog.cpp
  source/Plugins/Process/Windows/Live/ProcessWindowsLog.h
  source/Plugins/Process/Windows/Live/RegisterContextWindows.cpp
  source/Plugins/Process/Windows/Live/RegisterContextWindows.h
  source/Plugins/Process/Windows/Live/TargetThreadWindows.cpp
  source/Plugins/Process/Windows/Live/TargetThreadWindows.h
  source/Plugins/Process/Windows/Live/x64/RegisterContextWindows_x64.cpp
  source/Plugins/Process/Windows/Live/x64/RegisterContextWindows_x64.h
  source/Plugins/Process/Windows/Live/x86/RegisterContextWindows_x86.cpp
  source/Plugins/Process/Windows/Live/x86/RegisterContextWindows_x86.h
  source/Plugins/Process/Windows/LocalDebugDelegate.cpp
  source/Plugins/Process/Windows/LocalDebugDelegate.h
  source/Plugins/Process/Windows/MiniDump/CMakeLists.txt
  source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
  source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h
  source/Plugins/Process/Windows/MiniDump/RegisterContextWindowsMiniDump.cpp
  source/Plugins/Process/Windows/MiniDump/RegisterContextWindowsMiniDump.h
  source/Plugins/Process/Windows/MiniDump/ThreadWinMiniDump.cpp
  source/Plugins/Process/Windows/MiniDump/ThreadWinMiniDump.h
  source/Plugins/Process/Windows/ProcessWindows.cpp
  source/Plugins/Process/Windows/ProcessWindows.h
  source/Plugins/Process/Windows/ProcessWindowsLog.cpp
  source/Plugins/Process/Windows/ProcessWindowsLog.h
  source/Plugins/Process/Windows/RegisterContextWindows.cpp
  source/Plugins/Process/Windows/RegisterContextWindows.h
  source/Plugins/Process/Windows/TargetThreadWindows.cpp
  source/Plugins/Process/Windows/TargetThreadWindows.h
  source/Plugins/Process/Windows/x64/RegisterContextWindows_x64.cpp
  source/Plugins/Process/Windows/x64/RegisterContextWindows_x64.h
  source/Plugins/Process/Windows/x86/RegisterContextWindows_x86.cpp
  source/Plugins/Process/Windows/x86/RegisterContextWindows_x86.h
  source/Plugins/Process/win-minidump/CMakeLists.txt
  source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp
  source/Plugins/Process/win-minidump/ProcessWinMiniDump.h
  source/Plugins/Process/win-minidump/RegisterContextWindowsMiniDump.cpp
  source/Plugins/Process/win-minidump/RegisterContextWindowsMiniDump.h
  source/Plugins/Process/win-minidump/ThreadWinMiniDump.cpp
  source/Plugins/Process/win-minidump/ThreadWinMiniDump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12252.32876.patch
Type: text/x-patch
Size: 308722 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150821/c4ed878c/attachment-0001.bin>


More information about the lldb-commits mailing list