[Lldb-commits] [PATCH] D12237: [NativeProcessLinux] Pass around threads by reference

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 21 06:40:35 PDT 2015


labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.

Most NPL private functions took (shared) pointers to threads as arguments. This meant that the
callee could not be sure if the pointer was valid and so most functions were peppered with
null-checks. Now, I move the check closer to the source, and pass around the threads as
references (which are then assumed to be valid).

http://reviews.llvm.org/D12237

Files:
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12237.32824.patch
Type: text/x-patch
Size: 35252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150821/5c6abf81/attachment-0001.bin>


More information about the lldb-commits mailing list