[Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

[Dawn Perchik via lldb-commits]

dawn added a comment.

See inline comments.


================
Comment at: source/Commands/CommandObjectExpression.cpp:308
@@ -307,3 @@
-        else
-            options.SetLanguage(target->GetLanguage());
-
----------------
Why was this removed?  Doesn't this break the intent of the target.language setting?  That is:
    if expression --language option is set, use it,
    else if target.language option is set, use it,
    else default to the language of the frame.

Please keep this or preserve the above behavior another way.

================
Comment at: source/Expression/ClangUserExpression.cpp:1063
@@ +1062,3 @@
+    if (c_langs.find(language) != c_langs.end())
+        language = eLanguageTypeC_plus_plus_11;
+
----------------
If the user explicitly wanted the language to be C (either by expression --language or target.language settings), we should not give them C++11.


http://reviews.llvm.org/D11790