[Lldb-commits] [Diffusion] rL244865: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 13 10:48:29 PDT 2015


Yes, merging this is fine.

> On Aug 13, 2015, at 9:33 AM, Hans Wennborg <hans at chromium.org> wrote:
> 
> 
> Greg: you're the owner here. Approved for 3.7?
> 
> On Wed, Aug 12, 2015 at 10:21 PM, Jaydeep Patil
> <Jaydeep.Patil at imgtec.com> wrote:
>> Hi Hans,
>> 
>> Could you please merge it to release branch?
>> 
>> Thanks,
>> Jaydeep
>> 
>> -----Original Message-----
>> From: Jaydeep Patil
>> Sent: 13 August 2015 AM 09:17
>> To: Jaydeep Patil
>> Subject: Re: [Diffusion] rL244865: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint
>> 
>> jaydeep committed rL244865: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint.
>> 
>> [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint
>> 
>>  SUMMARY:
>>  The patch supports TAAwatch:addr packet. The patch also sets m_watchpoints_trigger_after_instruction
>>  to eLazyBoolNo when qHostInfo or qWatchpointSupportInfo is not supported by the target.
>> 
>>  Reviewers: jingham, clayborg
>>  Subscribers: nitesh.jain, mohit.bhakkad, sagar, bhushan and lldb-commits
>>  Differential Revision: http://reviews.llvm.org/D11747
>> 
>> 
>> Files:
>>  /lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
>>  /lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
>>  /lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
>> 
>> Users:
>>  jaydeep (Author)
>> 
>> http://reviews.llvm.org/rL244865
>> 
>> 
>> 



More information about the lldb-commits mailing list