[Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 11 19:12:50 PDT 2015


True that it only needs to be included if it's part of the api.  Are we
sure it can't happen through a transitive include?

As long as the user of liblldb doesn't see the declaration it shouldn't be
a problem.

On Tue, Aug 11, 2015 at 6:54 PM Chaoren Lin via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> chaoren added a subscriber: chaoren.
> chaoren added a comment.
>
> Sorry! I'll fix this as soon as I get home.
>
> I have a question though, isn't this only a problem if whatever's linking
> against lldb includes this header? This isn't in the API, so that shouldn't
> happen. I also don't know if it's correct to label it LLDB_API when it's
> not actually part of the API.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D11967
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150812/c558131f/attachment.html>


More information about the lldb-commits mailing list