[Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

[via lldb-commits]

Hi Ed,

We do not require to handle e_void case in GetData() as we have already 
checked if bytes_size greater than zero.
>     136    bool
>     137    Scalar::GetData (DataExtractor &data, size_t 
> limit_byte_size) const
>     138    {
>     139        size_t byte_size = GetByteSize();
>     140        static float f_val;
>     141        static double d_val;
> ->142         if (byte_size > 0)
>     143        {
Should I still add a case for e_void to clear the warnings?

Thanks and Regards,
Sagar

On Friday 07 August 2015 06:49 PM, Ed Maste wrote:
> On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Author: slthakur
>> Date: Fri Aug  7 01:39:38 2015
>> New Revision: 244308
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev
>> Log:
>> [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support
> Noticed a few new warnings after this change:
>
> ../tools/lldb/source/Core/Scalar.cpp:151:24: warning: enumeration
> value 'e_void' not handled in switch [-Wswitch]
>                  switch(m_type)
>                         ^
> ../tools/lldb/source/Core/Scalar.cpp:186:24: warning: enumeration
> value 'e_void' not handled in switch [-Wswitch]
>                  switch(m_type)
>                         ^
> ../tools/lldb/source/Core/Scalar.cpp:220:20: warning: enumeration
> value 'e_void' not handled in switch [-Wswitch]
>              switch(m_type)
>                     ^