[Lldb-commits] [PATCH] D11717: Bug 24332 - Fix the build of lldb under GNU/Linux when using autotools

[Bruce Mitchener]

brucem added a comment.

I don't have the authority to approve something to be committed afaik, but hopefully my comments here are useful.


================
Comment at: source/Plugins/Makefile:45
@@ -44,2 +44,3 @@
 PARALLEL_DIRS += JITLoader/GDB
+PARALLEL_DIRS += ScriptInterpreter/Python ScriptInterpreter/None
 endif
----------------
I'm not an expert in the autotools build system, but it seems likely that the ScriptInterpreters could be added to the global list of them rather than the per-OS ones. (This differs from what I wrote in the bug probably.)

It might be worth checking with Keno Fischer as well as he likes to have a build that doesn't use Python and he might have some feedback on this.

================
Comment at: source/Plugins/Makefile:52
@@ -50,2 +51,3 @@
 PARALLEL_DIRS += JITLoader/GDB
+PARALLEL_DIRS += ScriptInterpreter/Python ScriptInterpreter/None
 endif
----------------
As above.


Repository:
  rL LLVM

http://reviews.llvm.org/D11717