[Lldb-commits] [PATCH] D11482: Add target setting to have the language follow the frame's CU.

[Dawn Perchik]

dawn added a comment.

In http://reviews.llvm.org/D11482#214372, @jingham wrote:

> I'm not sure it is that hard.  For the expression parser, we can let folks ask for whatever they want, and then just give them whatever we need to give them.  The mapping is pretty simple, as I said, ask for ObjC, get ObjC++, ask for C++, for now get ObjC++, etc.


Cool!  That can be done in ClangExpressionParser's ctor if you like (see http://reviews.llvm.org/D11102 for an example).

> I don't know how you guys are doing Pascal expression evaluation?  Do you have a Pascal Clang front-end?  Do you do some kind of Pascal->C and then submit that to clang?  What do you actually need to set here.


Right now I have a hacked up clang FE until a full-blown Pascal FE can be plugged in.  The parsing is controlled by the language options set in the ClangExpressionParser's ctor.

> Part of the patches you have been submitting have been the breakpoint name chopper's handling of Pascal, but that's independent of the expression parser, and so doesn't so much feature in this discussion.


Sure, that's fine.  This patch was just a proposal as one way to solve the problem via option, and since target.language effects both expressions and breakpoints, it made sense that target.language-follows-frame should as well.  You'll notice my initial patch at http://reviews.llvm.org/D11102 affected only expressions and added C++ when OBJC was selected so the tests would still work, assuming that was what was intended.  Now that I understand your position better (thanks so much for clarifying), I'll go back to that patch and abandon this one.


Repository:
  rL LLVM

http://reviews.llvm.org/D11482