[Lldb-commits] [PATCH] D11473: Add option eTypeOptionHideEmptyAggregates.

Siva Chandra sivachandra at google.com
Thu Jul 23 14:27:24 PDT 2015


sivachandra added a comment.

On Thu, Jul 23, 2015 at 2:17 PM, Enrico Granata <granata.enrico at gmail.com> wrote:

> - Is there going to be a flag to "type summary add" for setting your new flag, or is this only meant for internal formatters?


I have only envisioned using such an option in scripts. If you feel it would be relevant/complete to expose it in the "type summary flags", I will do it as a follow up unless you want me to do it with this change itself.

> - How do you plan to test it?


I am testing my change locally by having a type summary script along with a synthetic children provider script which returns 0 children. I will add the same as a test for this patch.

> - If anything, maybe replace Print with Expand, to get ShouldExpandEmptyAggregates(). We are indeed printing the aggregate, just not "expanding" it


Will do it.


http://reviews.llvm.org/D11473







More information about the lldb-commits mailing list