[Lldb-commits] [PATCH] D11119: Parse breakpoint expressions using the language of the frame's CU.

[Jim Ingham]

jingham added a subscriber: jingham.
jingham added a comment.

That sounds fine, except you shouldn't call the option "expr-language" because we expr is the common abbreviation for the "expression" command, but the breakpoint specifications are not in general expressions.  In fact, the only breakpoint specifier that is an expression: --address would NOT take this option...  So that's a confusing name.

Since you are only going to add the language options to versions of breakpoint set that take some form of identifier (--name, --method --base-name) maybe --identifier-language would be better?

Jim


Repository:
  rL LLVM

http://reviews.llvm.org/D11119