[Lldb-commits] [PATCH] D11129: Fix for remote-linux test fails: use currently selected platform on target launch

[Ted Woodward]

ted added a subscriber: ted.
ted added a comment.

In http://reviews.llvm.org/D11129#203583, @tberghammer wrote:

> I agree that the current implementation is annoying with using the platform selected at target creation time, but changing the platform for a target after it is created might be dangerous because it can cache information from the platform.


Platform select at target creation time is needed for non-native targets. If I load a standalone Hexagon executable while on Linux, the Platform needs to be switched to the Hexagon Simulator Platform. If I load a Hexagon Linux executable while on Windows, the Platform needs to be switched to the Linux platform.

The current logic should only switch Platforms to match the Target if the currently selected Platform isn't compatible.


http://reviews.llvm.org/D11129