[Lldb-commits] [PATCH] D8417: Remove hack about the size of long doubles from DataExtractor

Tamas Berghammer tberghammer at google.com
Mon Jul 13 03:51:06 PDT 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL242019: Remove hack about the size of long doubles from DataExtractor (authored by tberghammer).

Changed prior to commit:
  http://reviews.llvm.org/D8417?vs=22191&id=29547#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D8417

Files:
  lldb/trunk/source/Core/DataExtractor.cpp

Index: lldb/trunk/source/Core/DataExtractor.cpp
===================================================================
--- lldb/trunk/source/Core/DataExtractor.cpp
+++ lldb/trunk/source/Core/DataExtractor.cpp
@@ -1830,10 +1830,8 @@
                             }
                             else if (item_bit_size == ast->getTypeSize(ast->LongDoubleTy))
                             {
-                                auto byte_size = item_byte_size;
                                 const auto &semantics = ast->getFloatTypeSemantics(ast->LongDoubleTy);
-                                if (&semantics == &llvm::APFloat::x87DoubleExtended)
-                                    byte_size = 10;
+                                const auto byte_size = (llvm::APFloat::getSizeInBits(semantics) + 7) / 8;
 
                                 llvm::APInt apint;
                                 if (GetAPInt(*this, &offset, byte_size, apint))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8417.29547.patch
Type: text/x-patch
Size: 934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150713/eb8d9fe5/attachment.bin>


More information about the lldb-commits mailing list