[Lldb-commits] [PATCH] D11066: Introduce a MainLoop class and switch llgs to use it

[Pavel Labath]

labath marked 3 inline comments as done.

================
Comment at: source/Host/posix/MainLoopPosix.cpp:171
@@ +170,3 @@
+
+        for (int fd: read_fds)
+        {
----------------
ovyalov wrote:
> Check for termination flag set here?
> It seems no need to read from sockets if signal handlers requested termination?
Ok, makes sense. I will add the check after every callback then, because by extension, there is no need to read from the second socket (if any) if the first socket requested termination.

================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:411
@@ -406,3 +410,3 @@
             printf ("Connection established.\n");
-            gdb_server.SetConnection (connection_up.release());
+            gdb_server.InitializeConnection (std::move(connection_up));
         }
----------------
ovyalov wrote:
> Could you log if error is returned?
Done. I've also merged the two branches a bit.


http://reviews.llvm.org/D11066