[Lldb-commits] [PATCH] D11049: [lldb-mi] size_t rather than MIuint for arg counts.
ki.stfu at gmail.com
Thu Jul 9 21:46:38 PDT 2015
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D11049#201815, @brucem wrote:
> I don't think other code within LLDB really uses const scalar parameters and they don't provide much protection against anything. (They don't do anything for the caller and they only provide a minor restriction for the callee.)
> Some const were removed in the MIuint to size_t patch as well, but if we decide to keep this, I can sort through and add them back.
> The value of these const annotations isn't clear though.
Ok. I agree about `const` for scalar and any other types in arguments: we shouldn't use `const` for variables that are passed by value.
Fix one inline comment and go ahead.
More information about the lldb-commits