[Lldb-commits] [PATCH] D11065: Skip oatdata and oatexec symbols in system at framework@boot.oat

[Tamas Berghammer]

tberghammer created this revision.
tberghammer added reviewers: ovyalov, dsrbecky.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: tberghammer.

Skip oatdata and oatexec symbols in system at framework@boot.oat

On Android the oatdata and the oatexec symbols in system at framework@boot.oat covers the full .text
section what causes issues with displaying unusable symbol name to the user and very slow unwinding
speed because the instruction emulation based unwind plans try to emulate all instructions in these
symbols. Don't add these symbols to the symbol list as they have no use for the debugger and they
are causing a lot of trouble.

http://reviews.llvm.org/D11065

Files:
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Index: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
===================================================================
--- source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -1795,7 +1795,16 @@
     static ConstString bss_section_name(".bss");
     static ConstString opd_section_name(".opd");    // For ppc64
 
-    //StreamFile strm(stdout, false);
+    // On Android the oatdata and the oatexec symbols in system at framework@boot.oat covers the full
+    // .text section what causes issues with displaying unusable symbol name to the user and very
+    // slow unwinding speed because the instruction emulation based unwind plans try to emulate all
+    // instructions in these symbols. Don't add these symbols to the symbol list as they have no
+    // use for the debugger and they are causing a lot of trouble.
+    // Filtering can't be restricted to Android because this special object file don't contain the
+    // note section specifying the environment to Android but the custom extension and file name
+    // makes it highly unlikely that this will collide with anything else.
+    bool skip_oatdata_oatexec = m_file.GetFilename() == ConstString("system at framework@boot.oat");
+
     unsigned i;
     for (i = 0; i < num_symbols; ++i)
     {
@@ -1809,7 +1818,10 @@
             (symbol_name == NULL || symbol_name[0] == '\0'))
             continue;
 
-        //symbol.Dump (&strm, i, &strtab_data, section_list);
+        // Skipping oatdata and oatexec sections if it is requested. See details above the
+        // definition of skip_oatdata_oatexec for the reasons.
+        if (skip_oatdata_oatexec && (::strcmp(symbol_name, "oatdata") == 0 || ::strcmp(symbol_name, "oatexec") == 0))
+            continue;
 
         SectionSP symbol_section_sp;
         SymbolType symbol_type = eSymbolTypeInvalid;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11065.29340.patch
Type: text/x-patch
Size: 1876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150709/a3d854a6/attachment.bin>