[Lldb-commits] [PATCH] LLGS Android target support

[Nico Weber]

On Tue, Apr 28, 2015 at 1:55 PM, Nico Weber <thakis at chromium.org> wrote:

> ================
> Comment at: cmake/LLDBDependencies.cmake:100
> @@ +99,3 @@
> +if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
> +  set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
> +  add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
> ----------------
> thakis wrote:
> > This doesn't look correct. Now every file that includes LLDBDependencies
> will have a custom command that builds tools/lldb/source/LLDB_vers.c. With
> ninja, this causes "ninja: warning: multiple rules generate
> tools/lldb/source/LLDB_vers.c. builds involving this target will not be
> correct; continuing anyway" for example (since there's more than one
> CMakeLists.txt that includes LLDBDependencies.txt).
> >
> > Maybe this rule could stay where it was?
> Ping? This is still broken 4 months later.
>

One last ping. If I don't hear back I'll try to fix it myself.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150707/c0b02b8c/attachment.html>