[Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

[Tamas Berghammer]

tberghammer added a comment.

In http://reviews.llvm.org/D10887#198532, @labath wrote:

> In http://reviews.llvm.org/D10887#198526, @chaoren wrote:
>
> > Using a shim results in about a 5M increase in the lldb-server binary
> >  because of the need to export all symbols dynamically. And still has those
> >  two bugs (which would be in the system libs, if linked dynamically).
>
>
> Couldn't this be avoided somehow (with some __attribute__ magic or something). In reality, we just need one symbol, "lldb_main", or such).
>
> And if that proves unfeasible and we have to statically link, I would prefer patching bugs in older libc over patching "features" in newer ones.


I think we can avoid the size increase if we compile lldb-server as we do it now and on older target launch it with calling main through dlopen.


http://reviews.llvm.org/D10887