[Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

Ed Maste emaste at freebsd.org
Mon Jun 29 11:58:40 PDT 2015


On 29 June 2015 at 14:47, Enrico Granata <egranata at apple.com> wrote:
>
>> I can see arguments for and against removing the default, but I think
>> removing it will cause a new warning to appear if Clang adds other new
>> kinds in the future.
>
> Yes. And I am slightly more worried about the silent failure when that happens rather than the warning per se - which is why I am hesitant to just say “yes please remove"

I mean the warning will prompt us to go and add any new missing enum
values if this happens -- especially if we enable -Werror :)

I don't feel too strongly one way or the other, but it seems we have
removed the defaults in all of these cases in the past.




More information about the lldb-commits mailing list