[Lldb-commits] [PATCH] [NativeProcessLinux] Refactor PtraceWrapper

Chaoren Lin chaorenl at google.com
Mon Jun 29 09:59:28 PDT 2015


================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:145
@@ -146,1 +144,3 @@
+        static Error
+        PtraceWrapper(int req, lldb::pid_t pid, void *addr, void *data, size_t data_size, long *result = nullptr);
 
----------------
It seems like every argument besides `req` could use a default. (`0` or `nullptr`).

http://reviews.llvm.org/D10808

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list