[Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

Ed Maste emaste at freebsd.org
Mon Jun 29 07:10:27 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: source/Target/Platform.cpp:1512
@@ +1511,3 @@
+       || arch.GetTriple ().getArch () == llvm::Triple::mipsel)
+           map_anon = 0x800;
+
----------------
labath wrote:
> Wouldn't this be better in PlatformLinux? What are the odds of this constant being correct on non-linux platforms?
Yes, this is incorrect on FreeBSD.

/usr/include/sys/mman.h
84:#define      MAP_ANON         0x1000 /* allocated from memory, swap space */
86:#define      MAP_ANONYMOUS    MAP_ANON /* For compatibility. */

http://reviews.llvm.org/D10685

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list