[Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

[Greg Clayton]

We probably need to pass in an architecture:

  virtual uint64_t
  Platform:: ConvertMmapFlagsToPlatform (const ArchSpec &arch, unsigned flags);

Then have all callers specify an architecture.


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Platform/Linux/PlatformLinux.cpp:941
@@ +940,3 @@
+    uint64_t map_anon=MAP_ANON;
+    ArchSpec target_arch = HostInfoBase::GetArchitecture();
+
----------------
tberghammer wrote:
> ovyalov wrote:
> > We may need a special care for remote debugging scenario - i.e. use HostInfoBase::GetArchitecture() if IsHost() otherwise get archspec from remote target via GetRemoteSystemArchitecture
> We should use GetSystemArchitecture() what do this (with some additional caching)
You can't just get the Host for its architecture. We might need to change this function to take an "const ArchSpec &arch" as an argument and have the caller specify the right architecture using the current target.

http://reviews.llvm.org/D10685

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/