[Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

Siva Chandra sivachandra at google.com
Thu Jun 25 06:46:45 PDT 2015


On Wed, Jun 24, 2015 at 7:21 PM, Enrico Granata <egranata at apple.com> wrote:
> I would like for your repro case to be added as a test case, so that we can catch any future regressions in this area
> If you have a few spare minutes and want to handle that, great; if not I’ll gladly do it tomorrow morning.

If there is no rush, I will definitely do it by the end of this week.

>> This seems meaningful now; if  we are holding on to a SBValue
>> object and change settings, we want the behavior of that SBValue
>> object to change according to the settings.
>
> Exactly. That’s the whole reason to have ValueImpl in the first place.

OK. Before this change, this intent was not apparent.




More information about the lldb-commits mailing list