[Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

Oleksiy Vyalov ovyalov at google.com
Wed Jun 24 14:32:32 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Platform/Linux/PlatformLinux.cpp:940
@@ -939,1 +939,3 @@
     uint64_t flags_platform = 0;
+    uint64_t map_anon=MAP_ANON;
+    ArchSpec target_arch = HostInfoBase::GetArchitecture();
----------------
Please add spaces around equal sign.

================
Comment at: source/Plugins/Platform/Linux/PlatformLinux.cpp:941
@@ +940,3 @@
+    uint64_t map_anon=MAP_ANON;
+    ArchSpec target_arch = HostInfoBase::GetArchitecture();
+
----------------
We may need a special care for remote debugging scenario - i.e. use HostInfoBase::GetArchitecture() if IsHost() otherwise get archspec from remote target via GetRemoteSystemArchitecture

http://reviews.llvm.org/D10685

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list