[Lldb-commits] [lldb] r240550 - Remove SetResumeState from POSIXThread::RefreshStateAfterStop

Ed Maste emaste at freebsd.org
Wed Jun 24 09:39:22 PDT 2015


Author: emaste
Date: Wed Jun 24 11:39:22 2015
New Revision: 240550

URL: http://llvm.org/viewvc/llvm-project?rev=240550&view=rev
Log:
Remove SetResumeState from POSIXThread::RefreshStateAfterStop

With the removal of ProcessLinux in r240543 this code is used only on
FreeBSD. FreeBSD isn't affected by whichever issue originally prompted
the addition of SetResumeState, so just remove it.

As discussed on the mailing list (and mentioned in a FIXME comment)
it shouldn't be called there.

Modified:
    lldb/trunk/source/Plugins/Process/FreeBSD/POSIXThread.cpp

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/POSIXThread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/POSIXThread.cpp?rev=240550&r1=240549&r2=240550&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/POSIXThread.cpp (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/POSIXThread.cpp Wed Jun 24 11:39:22 2015
@@ -95,7 +95,6 @@ POSIXThread::GetMonitor()
     return process.GetMonitor();
 }
 
-// Overridden by FreeBSDThread; this is used only on Linux.
 void
 POSIXThread::RefreshStateAfterStop()
 {
@@ -112,11 +111,6 @@ POSIXThread::RefreshStateAfterStop()
         const bool force = false;
         GetRegisterContext()->InvalidateIfNeeded (force);
     }
-    // FIXME: This should probably happen somewhere else.
-    SetResumeState(eStateRunning, true);
-    Log *log (ProcessPOSIXLog::GetLogIfAllCategoriesSet (POSIX_LOG_THREAD));
-    if (log)
-        log->Printf ("POSIXThread::%s (tid = %" PRIi64 ") setting thread resume state to running", __FUNCTION__, GetID());
 }
 
 const char *





More information about the lldb-commits mailing list