[Lldb-commits] [PATCH] Make SBValue::GetNonSyntheticValue return really that.

[Greg Clayton]

So the root shared pointer is always the original untouched value object (non-dynamic and non-synthetic). The ValueImpl sets booleans that allow it to say if it needs to get the dynamic or synthetic values from the untouched root shared pointer. These booleans for dynamic and synthetic are set by current "settings" values. The old SBValue::GetNonSyntheticValue() should be doing the right thing without the need for any changes: it creates a new SBValue that has a untouched root value object and a ValueImpl that says "never fetch the synthetic value" -- the **false** in the statement below:

  ValueImplSP proxy_sp(new ValueImpl(m_opaque_sp->GetRootSP(),m_opaque_sp->GetUseDynamic(),false));

So I don't think any change is needed. Were you seeing otherwise?


http://reviews.llvm.org/D10581

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/