[Lldb-commits] [PATCH] Fix handling of hijacked events in synchronous mode

jingham at apple.com jingham at apple.com
Fri May 8 08:50:53 PDT 2015


That seems like something you should fix on the MI side.  The point of synchronous execution is that you don't have to worry about the events.  Now you are introducing an extra event that everybody is going to have to deal with.  That doesn't seem right to me.

Jim

> On May 8, 2015, at 8:46 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> @jingham wrote:
> 
>> I don't understand this.  The Command line worked just fine and informed the user about stops without this extra event being generated.  Why does the MI need what the command line doesn't?
> 
> 
> The CL notifies user by printing the (lldb) prompt when something happened (exception or BP hit etc.) and execution was stopped. If user don't want to wait he can press ^C and execution will be interrupted and the (lldb) prompt will be printed.
> 
> Usually IDE uses MI in async mode and therefore it can't determine whether execution was stopped or not. In that case MI should notify IDE using the *stopped notification and IDE always expects to see it when execution was stopped. This patch fixes the *stopped notification in sync mode (which is used for handling of --source option) because IDE expects to see *stopped in any case in despite of current mode of debugger
> 
> 
> http://reviews.llvm.org/D9371
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the lldb-commits mailing list