[Lldb-commits] [lldb] r235036 - [TestRvalueReferences] Fix an expectation.

Siva Chandra sivachandra at google.com
Wed Apr 15 11:35:29 PDT 2015


Author: sivachandra
Date: Wed Apr 15 13:35:29 2015
New Revision: 235036

URL: http://llvm.org/viewvc/llvm-project?rev=235036&view=rev
Log:
[TestRvalueReferences] Fix an expectation.

Summary:
If 'i' is an rvalue reference to an 'int', evaluating it with the
'expression' command will return an 'int' value and not an 'int &&'.
Before this patch, an 'int &&' type was expected.

Enabled the test for clang and gcc as all parts of the test now pass
when the testcase is compiled with them.

Test Plan: dotest.py -C <gcc|clang> -p TestRvalueReferences

Reviewers: spyffe, chaoren

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D9005

Modified:
    lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py

Modified: lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py?rev=235036&r1=235035&r2=235036&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py (original)
+++ lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py Wed Apr 15 13:35:29 2015
@@ -19,8 +19,6 @@ class RvalueReferencesTestCase(TestBase)
         self.static_method_commands()
 
     #rdar://problem/11479676
-    @expectedFailureClang("rdar://problem/11479676 pr16762: Expression evaluation of an rvalue-reference does not show the correct type.")
-    @expectedFailureGcc("GCC (4.7) does not emit correct DWARF tags for rvalue-references")
     @expectedFailureIcc("ICC (13.1, 14-beta) do not emit DW_TAG_rvalue_reference_type.")
     @dwarf_test
     def test_with_dwarf_and_run_command(self):
@@ -50,7 +48,7 @@ class RvalueReferencesTestCase(TestBase)
                     substrs = ["i = 0x", "&i = 3"])
 
         self.expect("expression -- i",
-                    startstr = "(int &&",
+                    startstr = "(int) ",
                     substrs = ["3"])
 
         self.expect("breakpoint delete 1")





More information about the lldb-commits mailing list