[Lldb-commits] [PATCH] Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline.

[Pavel Labath]

REPOSITORY
  rL LLVM

================
Comment at: test/plugins/builder_base.py:101
@@ +100,3 @@
+
+        return '%s=%s%s%s' % (k, quote, escape(v, quote), quote)
+
----------------
What is the agent that is going to be parsing this?

If it is a posix shell, then the single quotes there don't work the way you expect them to:
  $ echo 'a string with a \' inside'
  > '
  a string with a \ inside
  
I recommend using double quotes and escaping ", `, $ and \.
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

http://reviews.llvm.org/D8942

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/