[Lldb-commits] [PATCH] Add logging plugin for Winodows

Adrian McCarthy amccarth at google.com
Thu Apr 9 14:07:37 PDT 2015


Hi zturner,

Adds a ProcessWindowsLog, patterned off ProcessPosixLog and others.  (Nothing uses it yet.  I'll do that in a separate patch.

But it does initialize, and you can issue lldb commands like:

(lldb) log list windows
(lldb) log list enable windows all
(lldb) log disable windows memory

There's already a lot of code duplication among the logging classes, so this addition doesn't it make it much worse.  It seems there's almost nothing POSIX-specific in ProcessPOSIXLog, so that class could be used as a base to reduce a bunch of the code duplication.  If that seems reasonable, I'll go that route.

http://reviews.llvm.org/D8937

Files:
  source/Initialization/SystemInitializerCommon.cpp
  source/Plugins/Process/Windows/CMakeLists.txt
  source/Plugins/Process/Windows/ProcessWindowsLog.cpp
  source/Plugins/Process/Windows/ProcessWindowsLog.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8937.23531.patch
Type: text/x-patch
Size: 11782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150409/6725a732/attachment.bin>


More information about the lldb-commits mailing list