[Lldb-commits] [PATCH] Don't compile scripts directory if LLDB_DISABLE_PYTHON is set

Zachary Turner zturner at google.com
Tue Apr 7 07:56:07 PDT 2015


Lgtm
On Tue, Apr 7, 2015 at 2:53 AM Pavel Labath <labath at google.com> wrote:

> Hi zturner,
>
> What looks like a typo has caused the scripts/Python directory to be
> compiled on non-Windows
> platforms even with LLDB_DISABLE_PYTHON, which failed if Python.h was
> unavaiable. This changes
> the condition to avoid compilation if LLDB_DISABLE_PYTHON is set.
>
> http://reviews.llvm.org/D8855
>
> Files:
>   CMakeLists.txt
>
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt
> +++ CMakeLists.txt
> @@ -4,7 +4,7 @@
>
>  #add_subdirectory(include)
>  add_subdirectory(docs)
> -if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" OR NOT LLDB_DISABLE_PYTHON)
> +if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT LLDB_DISABLE_PYTHON)
>    add_subdirectory(scripts)
>  endif ()
>  add_subdirectory(source)
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150407/63a93ae4/attachment.html>


More information about the lldb-commits mailing list