[Lldb-commits] [PATCH] LLDB ARM Register context support

[Muhammad Omair Javaid]

I have updated the patch after incorporating suggestions.

I have changed the alpha order issues and also I have marked argument registers as suggested.

About arm frame pointer I am still not sure if R11 is the right choice but as it works on nexus 5 I have made that change. Arm FP should be r7 in thumb mode and r11 in arm mode.

I am not sure if gnu-linux even uses a frame pointer.

Regarding arm trap handling, there is still a bit of work required to handle arm/thumb mode trap in little/big endian modes. I have skipped that change for now and will work on that and submit it later.

Host/Filesystem and Host/Pipeposix changes were some issues that were only visible on my build system so I have removed them from the patch and will later submit them with better solution and convincing arguments.

Looking forward to your consideration for accepting these changes.

PS: Can someone kindly help me with getting these patches committed or getting the commit rights to do it myself once they are accepted.

Thanks!


http://reviews.llvm.org/D8719

Files:
  source/Plugins/Process/Linux/CMakeLists.txt
  source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
  source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
  source/Plugins/Process/Linux/NativeThreadLinux.cpp
  source/Plugins/Process/POSIX/CMakeLists.txt
  source/Plugins/Process/POSIX/POSIXThread.cpp
  source/Plugins/Process/POSIX/ProcessPOSIX.cpp
  source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm.cpp
  source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm.h
  source/Plugins/Process/Utility/CMakeLists.txt
  source/Plugins/Process/Utility/RegisterContextLinux_arm.cpp
  source/Plugins/Process/Utility/RegisterContextLinux_arm.h
  source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp
  source/Plugins/Process/Utility/RegisterContextPOSIX_arm.h
  source/Plugins/Process/Utility/RegisterInfos_arm.h
  source/Plugins/Process/Utility/lldb-arm-register-enums.h
  source/Plugins/Process/elf-core/CMakeLists.txt
  source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm.cpp
  source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm.h
  source/Plugins/Process/elf-core/ThreadElfCore.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8719.23311.patch
Type: text/x-patch
Size: 87546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150407/dfaf5bbf/attachment.bin>