[Lldb-commits] [PATCH] Fix test expectation for aarch64 in several test case

Tamas Berghammer tberghammer at google.com
Wed Apr 1 09:31:07 PDT 2015

Comment at: test/lldbplatformutil.py:4
@@ +3,3 @@
+def check_first_register_readable(self):
+    if self.getArchitecture() in ['x86_64', 'i386']:
ovyalov wrote:
> ovyalov wrote:
> > self argument looks a little awkward here since there is no class around - maybe use test_case instead of self? 
> Since this function depends on methods and data from lldbtest what do you think about moving it into lldbtest.py?
I think lldbtest.py already have too much different responsibility so I prefer to keep this platform dependent code separately for readability reasons. Currently it looks a bit strange with just 1 small function in it but I guess there is a lot of duplicated logic in the test cases what should be moved out to a utility class like this.

If you read the comment at the top of lldbtest.py you will see that it already do much more then it was originally designed for (and currently documented). I would prefer to split that class up in the future instead of adding more thing into it.



More information about the lldb-commits mailing list