[Lldb-commits] [lldb] r233703 - Changed a function to static.

Hafiz Abid Qadeer hafiz_abid at mentor.com
Tue Mar 31 09:30:29 PDT 2015


Author: abidh
Date: Tue Mar 31 11:30:29 2015
New Revision: 233703

URL: http://llvm.org/viewvc/llvm-project?rev=233703&view=rev
Log:
Changed a function to static.
A temp object was being created to call StripOffFileName. This function
is not dependent on class members so I am making it static.
No regression on testsuite on Linux.


Modified:
    lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp
    lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp
    lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp
    lldb/trunk/tools/lldb-mi/MIUtilFileStd.h

Modified: lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp?rev=233703&r1=233702&r2=233703&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp Tue Mar 31 11:30:29 2015
@@ -114,7 +114,7 @@ CMICmdCmdFileExecAndSymbols::Execute(voi
     const CMIUtilString &rStrKeyWkDir(rSessionInfo.m_constStrSharedDataKeyWkDir);
     if (!rSessionInfo.SharedDataRetrieve<CMIUtilString>(rStrKeyWkDir, strWkDir))
     {
-        strWkDir = CMIUtilFileStd().StripOffFileName(strExeFilePath);
+        strWkDir = CMIUtilFileStd::StripOffFileName(strExeFilePath);
         if (!rSessionInfo.SharedDataAdd<CMIUtilString>(rStrKeyWkDir, strWkDir))
         {
             SetError(CMIUtilString::Format(MIRSRC(IDS_DBGSESSION_ERR_SHARED_DATA_ADD), m_cmdData.strMiCmd.c_str(), rStrKeyWkDir.c_str()));

Modified: lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp?rev=233703&r1=233702&r2=233703&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp Tue Mar 31 11:30:29 2015
@@ -216,7 +216,7 @@ CMICmnLogMediumFile::FileFormFileNamePat
     CMIUtilString strPathName;
     if (CMIUtilSystem().GetLogFilesPath(strPathName))
     {
-        const CMIUtilString strPath = CMIUtilFileStd().StripOffFileName(strPathName);
+        const CMIUtilString strPath = CMIUtilFileStd::StripOffFileName(strPathName);
 
 // ToDo: Review this LINUX log file quick fix so not hidden
 // AD:

Modified: lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp?rev=233703&r1=233702&r2=233703&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp Tue Mar 31 11:30:29 2015
@@ -254,7 +254,7 @@ CMIUtilFileStd::GetLineReturn(void) cons
 // Throws:  None.
 //--
 CMIUtilString
-CMIUtilFileStd::StripOffFileName(const CMIUtilString &vDirectoryPath) const
+CMIUtilFileStd::StripOffFileName(const CMIUtilString &vDirectoryPath)
 {
     const MIint nPos = vDirectoryPath.rfind('\\');
     MIint nPos2 = vDirectoryPath.rfind('/');

Modified: lldb/trunk/tools/lldb-mi/MIUtilFileStd.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilFileStd.h?rev=233703&r1=233702&r2=233703&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilFileStd.h (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilFileStd.h Tue Mar 31 11:30:29 2015
@@ -36,7 +36,7 @@ class CMIUtilFileStd : public CMICmnBase
     bool IsOk(void) const;
     bool IsFileExist(const CMIUtilString &vFileNamePath) const;
     const CMIUtilString &GetLineReturn(void) const;
-    CMIUtilString StripOffFileName(const CMIUtilString &vDirectoryPath) const;
+    static CMIUtilString StripOffFileName(const CMIUtilString &vDirectoryPath);
 
     // Overridden:
   public:





More information about the lldb-commits mailing list