[Lldb-commits] [PATCH] Fix test expectation for aarch64 in several test case
ovyalov at google.com
Mon Mar 30 18:07:55 PDT 2015
Please see my comments.
Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:98
@@ -97,1 +97,3 @@
+ def check_register_read_working(self):
+ if self.getArchitecture() in ['x86_64', 'i386']:
> Hi Tamas,
> Can we put this function in one place and use it from there instead on duplicating it in every other file?
> In my opinion we should consider separating such tests by architecture and put them in a library or file that can imported otherwise these will be very hard to maintain as our test set grows large.
Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:105
@@ +104,3 @@
+ # TODO: Add check for other architectures
+ self.fail("Unsupported architecture for test case")
Could you print here self.getArchitecture()?
More information about the lldb-commits