[Lldb-commits] [PATCH] Fix TestSendSignal.py for remote.

[Oleksiy Vyalov]

Please see my comments.


================
Comment at: test/functionalities/signal/TestSendSignal.py:87
@@ +86,3 @@
+        if lldb.remote_platform:
+            got_event = process_listener.WaitForEventForBroadcasterWithType(5, broadcaster, lldb.SBProcess.eBroadcastBitStateChanged, event)
+            event_type = lldb.SBProcess.GetStateFromEvent(event)
----------------
Could you wrap added snippet into a new method so it can be reused both for eStateConnected and eStateRunning?

================
Comment at: test/functionalities/signal/TestSendSignal.py:88
@@ +87,3 @@
+            got_event = process_listener.WaitForEventForBroadcasterWithType(5, broadcaster, lldb.SBProcess.eBroadcastBitStateChanged, event)
+            event_type = lldb.SBProcess.GetStateFromEvent(event)
+            self.assertTrue (got_event, "Got an event")
----------------
Swap this instruction with self.assertTrue (got_event, "Got an event") ?
It seems there is no need to call GetStateFromEvent if !got_event.

http://reviews.llvm.org/D8714

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/