[Lldb-commits] [PATCH] TestRecursiveInferior fixed on Linux

Vince Harron vince at nethacker.com
Fri Mar 27 15:14:41 PDT 2015


Hi clayborg, sivachandra,

Updated test to reflect that Linux and Darwin behave the same now.

Removed @expectedFailureLinux for passing tests.

http://reviews.llvm.org/D8678

Files:
  test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py

Index: test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
===================================================================
--- test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
+++ test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
@@ -67,7 +67,6 @@
         self.recursive_inferior_crashing_step_after_break()
 
     @skipIfFreeBSD # llvm.org/pr16684
-    @expectedFailureLinux('llvm.org/pr16684')
     def test_recursive_inferior_crashing_step_after_break_dwarf(self):
         """Test that lldb functions correctly after stepping through a crash."""
         self.buildDwarf()
@@ -80,7 +79,6 @@
         self.recursive_inferior_crashing_expr_step_expr()
 
     @expectedFailureFreeBSD('llvm.org/pr15989') # Couldn't allocate space for the stack frame
-    @expectedFailureLinux('llvm.org/pr15989') # Couldn't allocate space for the stack frame
     def test_recursive_inferior_crashing_expr_step_and_expr_dwarf(self):
         """Test that lldb expressions work before and after stepping after a crash."""
         self.buildDwarf()
@@ -208,15 +206,8 @@
         self.runCmd("run", RUN_SUCCEEDED)
         self.check_stop_reason()
 
-        expected_state = 'exited' # Provide the exit code.
-        if sys.platform.startswith("darwin"):
-            expected_state = 'stopped' # TODO: Determine why 'next' and 'continue' have no effect after a crash.
-
         self.expect("next",
-            substrs = ['Process', expected_state])
-
-        if not(sys.platform.startswith("darwin")): # if stopped, we will have a process around
-            self.expect("thread list", error=True,substrs = ['Process must be launched'])
+            substrs = ['Process', 'stopped'])
 
     def recursive_inferior_crashing_expr_step_expr(self):
         """Test that lldb expressions work before and after stepping after a crash."""

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8678.22830.patch
Type: text/x-patch
Size: 1925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150327/42aaac18/attachment.bin>


More information about the lldb-commits mailing list