[Lldb-commits] [PATCH] Don't require AVX registers if the target CPU doesn't have them

Vince Harron vince at nethacker.com
Fri Mar 27 11:27:51 PDT 2015


Tamas/Ed, if you have any problems with my commit, I'll fix them

http://reviews.llvm.org/rL232137#2b74499f


================
Comment at: test/tools/lldb-server/TestLldbGdbServer.py:465
@@ +464,3 @@
+    def targetHasAVX(self):
+        # Need to do something different for non-Linux/Android targets
+        if lldb.remote_platform:
----------------
emaste wrote:
> Would be nice to see a switch on sys.platform or equivalent even if Linux is the only case right now.
done http://reviews.llvm.org/rL232137#2b74499f

================
Comment at: test/tools/lldb-server/TestLldbGdbServer.py:472-474
@@ +471,5 @@
+
+        f = open(cpuinfo_path, 'r')
+        cpuinfo = f.read()
+        f.close()
+        return " avx " in cpuinfo
----------------
tberghammer wrote:
> Please remove the local copy of cpuinfo for remote platforms
done http://reviews.llvm.org/rL232137#2b74499f

http://reviews.llvm.org/D8189

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list