[Lldb-commits] [PATCH] Fix expression evaluation with logs (step + verbose) enabled.
jingham at apple.com
Thu Mar 26 15:06:23 PDT 2015
I don't understand how calling ReportRegisterState when the takedown had already been done could cause the error you report - though without more details about what you are doing it's hard to say for sure.
After all, within ShouldStop the m_thread in the ThreadPlan must still be valid, and all ReportRegisterState does is pretty print its register context. That also should still be good, if it is not, something is wrong at a deeper level.
And anyway, this code only does anything at all if the Expression log is on and in verbose mode. Did you have that log on?
I don't have a strong objection to this change, after all this is just a log output. OTOH I worry that it is just papering over some real problem, so it would be better to figure out what that is.
More information about the lldb-commits