[Lldb-commits] [PATCH] Fix type detection for 'char' when it is unsigned

Tamas Berghammer tberghammer at google.com
Thu Mar 26 10:30:58 PDT 2015

In http://reviews.llvm.org/D8636#147410, @sivachandra wrote:

> Just a drive by comment: You mention "causing several test failure". Does your patch fix them? If yes, then are they currently skipped or marked xfail? If yes again, you should probably enable them in this patch.
> At the very least, it will be helpful if you can give an example of a failing test.

This is causing failures on android-aarch64 what is currently not in the state where we want to start XFAIL-ing tests. The issue effects multiple test cases (e.g.: TestCStrings, TestFunctionTypes) but all of them have some different (unrelated) issue also as android-aarch64 is still not in a good shape. This CL and http://reviews.llvm.org/D8634 will fix e.g.: TestCStrings on android aarch64 (and about 20 other failures where I haven't checked which CL makes the difference).



More information about the lldb-commits mailing list