[Lldb-commits] [PATCH] Fix race condition in Target::Launch

Zachary Turner zturner at google.com
Thu Mar 26 10:17:27 PDT 2015

In http://reviews.llvm.org/D8562#147401, @jingham wrote:

> I prefer treating the synchronous & async cases separately.  It seems a little easier to read to me, and we're more likely to have to modify one or the other branch, so keeping them separate is slightly preferable from that standpoint.
> Is that SyncIOHandler hack needed in the synchronous case?
> Jim

Not sure, you tell me?  :)  I guess probably not though, so I can remove it (which also makes the argument for keeping the sync and async cases separate a no-brainer) since at that point there's very little duplication left.  Is this good to go after removing the SyncIOHandler hack?



More information about the lldb-commits mailing list