[Lldb-commits] [PATCH] Fix type detection for 'char' when it is unsigned

[Greg Clayton]

Shouldn't we return an unsigned char type even if the name says "char"? See inlined comment.


================
Comment at: source/Symbol/ClangASTContext.cpp:1023
@@ +1022,3 @@
+                        if (QualTypeMatchesBitSize (bit_size, ast, ast->CharTy))
+                            return ClangASTType (ast, ast->CharTy.getAsOpaquePtr());
+                    }
----------------
Shouldn't this line be:

```return ClangASTType (ast, ast->UnsignedCharTy.getAsOpaquePtr());```

http://reviews.llvm.org/D8636

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/