[Lldb-commits] [PATCH] Use Android device serial number instead of hostname as a target identifier within module cache.

Tamas Berghammer tberghammer at google.com
Wed Mar 25 03:39:20 PDT 2015

Comment at: source/Plugins/Platform/Android/AdbClient.h:33-37
@@ -31,4 +32,7 @@
+    static Error
+    CreateByDeviceID (const char* device_id, AdbClient &adb);
     AdbClient () = default;
     explicit AdbClient (const std::string &device_id);
What is your opinion about using a proper factory pattern instead of this combined approach? If we worry about the performance implication caused by querying the device list every time then we can make that optional.

Note: I plan to add a few more factory method to create an AdbClient based on -e (emulator) and -d (device) flags the same way as adb do it.

Comment at: source/Plugins/Platform/Android/AdbClient.h:39-40
@@ -34,4 +38,4 @@
     SetDeviceID (const std::string& device_id);
Can we remove this function (or make it private)?



More information about the lldb-commits mailing list