[Lldb-commits] [PATCH] Force iteration over FieldDecls and RecordDecls in deterministic order.

Zachary Turner zturner at google.com
Tue Mar 24 10:24:02 PDT 2015

This bug isn't specific to Microsoft layout. Clang as a general rule
requires fields to be added in offset order, and iterating over a dense map
doesn't give you that.

I'll let majnemer or rnk comment on the ExternalASTSource interface
On Tue, Mar 24, 2015 at 10:15 AM Sean Callanan <scallanan at apple.com> wrote:

> As an aside, when laying out a RecordDecl, you have the ordering for its
> fields right in the RecordDecl.  If MicrosoftRecordLayoutBuilder relying on
> the llvm::DenseMap for ordering, I think it's MicrosoftRecordLayoutBuilder
> that has the bug.  By my understanding of how record layout works, it
> should only be using the map to go from fields/bases to offsets – nothing
> else.
>   rL LLVM
> http://reviews.llvm.org/D8512
>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150324/c3e291d0/attachment.html>

More information about the lldb-commits mailing list