[Lldb-commits] [PATCH] Use eFlagRequiresFrame instead of manually checking in CommandObjectThread.cpp.

Jason Molenda jmolenda at apple.com
Mon Mar 23 20:20:21 PDT 2015

Good change as long as it accomplishes the same thing as your null check against GetStackFrameAtIndex(0).  eFlagRequiresFrame is slightly different, checking that the ExecutionContext got a frame but I suppose the ECX got it from the same place -- GetStackFrameAtIndex(0) so it should be fine.

I wouldn't raise such a pedantic point except that lldb is clearly in an odd state when this code path is erroring out; normal assumptions may not be safe.



More information about the lldb-commits mailing list