[Lldb-commits] [PATCH] Add a missing null pointer check in CommandObjectThread.cpp.

jingham at apple.com jingham at apple.com
Mon Mar 23 19:18:40 PDT 2015


Yes, I think there are a lot of places around in lldb where we assume that if you have a valid thread you have a valid frame 0.  You're not going to get very far if you don't get that right.

Jim

> On Mar 23, 2015, at 6:48 PM, Jason Molenda <jmolenda at apple.com> wrote:
> 
> Not worth changing the patch but fwiw you could have added eFlagRequiresFrame to the CommandObjectParsed flags for this command to do the same thing.  My main reaction echoes Jim's - I don't know what it means to have a thread and no frame 0.  But given that two lldb devs have hit it, I guess early in the startup of a new platform you can get hit this.
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D8554
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the lldb-commits mailing list