[Lldb-commits] [PATCH] Fix race condition in Target::Launch
zturner at google.com
Mon Mar 23 15:50:12 PDT 2015
Comment at: source/Target/Target.cpp:2605-2606
@@ -2604,4 +2610,1 @@
- if (!synchronous_execution)
- m_process_sp->RestoreProcessEvents ();
> Can we use a mixed code (for sync and async execution) to avoid copy-paste?
I'm not crazy about the copy/paste either, but I thought this separation made the logic easier to follow. Let's see what Jim or Greg says, I don't feel very strongly, so if there's a consensus one way or the other I'll just go with the consensus.
Comment at: source/Target/Target.cpp:2627
@@ -2625,2 +2626,3 @@
> it's really needed?
I'm still learning this section of the code, but if we hijack the events, surely we need to restore them?
More information about the lldb-commits