[Lldb-commits] [PATCH] Fetch module specification from remote process also

[Greg Clayton]

Fix the "std::string" arguments as noted in inline comments and this is good to go.


================
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:291
@@ +290,3 @@
+        virtual lldb_private::FileSpec
+        GetLoadedModuleFileSpec(const std::string& module_path) = 0;
+
----------------
change this parameter to "const char *' or a "const llvm::StringRef &" unless there really is a need for a std::string.

================
Comment at: include/lldb/Target/Process.h:3009
@@ +3008,3 @@
+    {
+        return false;
+    }
----------------
add a "module_spec.Clear();" before the return false.

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3983
@@ +3982,3 @@
+lldb_private::FileSpec
+NativeProcessLinux::GetLoadedModuleFileSpec(const std::string& module_path)
+{
----------------
change argument to "const char *" or "const llvm::StringRef &"

http://reviews.llvm.org/D8547

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/