[Lldb-commits] [PATCH] Fix lld command on Windows for many tests

Zachary Turner zturner at google.com
Mon Mar 23 09:31:50 PDT 2015


================
Comment at: test/lldbtest.py:1498
@@ -1494,1 +1497,3 @@
+                 'CFLAGS_EXTRAS' : "%s %s -I%s" % (stdflag, stdlibflag, os.path.join(os.environ["LLDB_SRC"], "include")),
+                 'LD_EXTRAS' : "-L%s\..\lib -L%s -lliblldb" % self.lib_dir}
         if self.TraceOn():
----------------
Not crazy about this relative path.  Maybe if we're on Windows, we should be setting up an environment variable like LLDB_WIN32_IMPLIB_DIR.  check dotest.py:setupSysPath() for a good place to do this.  Then we can just read that environment variable here.  Same comment for the location below.

http://reviews.llvm.org/D8494

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list